Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Hold Active Receiver and Task Cleanup in Proposal Task #3784

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Don't Hold Active Receiver and Task Cleanup in Proposal Task #3784

merged 2 commits into from
Oct 28, 2024

Conversation

bfish713
Copy link
Collaborator

@bfish713 bfish713 commented Oct 22, 2024 •
edited
Loading

Closes #<ISSUE_NUMBER>

This PR:

  • Deactivates the receiver held only for the result of the event dependency. We activated after we are fulfill the deps
  • Cancels old proposal tasks once those views timeout or complete

This PR does not:

Key places to review:

@bfish713 bfish713 changed the title proposal dep takes inactive receiver and cancel tasks Don't Hold Active Receiver and Task Cleanup in Proposal Task Oct 22, 2024
@bfish713 bfish713 marked this pull request as ready for review October 22, 2024 03:37
@bfish713 bfish713 merged commit bd976bd into main Oct 28, 2024
24 checks passed
@bfish713 bfish713 deleted the bf/cancel_deps branch October 28, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-maron rob-maron rob-maron approved these changes

Assignees

@lukeiannucci lukeiannucci

@rob-maron rob-maron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfish713 @rob-maron @lukeiannucci